Dump testharness test failures on window for debug mode #466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return testURLs.map(function(testURL) { | ||
| var tests = Object.keys(failures[testURL]); | ||
| tests.sort(); | ||
| return ( |
Contributor
There was a problem hiding this comment.
Can we use JSON.stringify here instead?
Contributor
Author
There was a problem hiding this comment.
I believe I had to write my own stringify() because the double quotes from JSON.stringify() fails lint. I should add a comment explaining this.
Contributor
There was a problem hiding this comment.
Could you use JSON.stringify and then a string replace for " to '? That seems more robust/easier to read.
Contributor
Author
There was a problem hiding this comment.
That would fail for "strings with 's in them".
Contributor
Author
There was a problem hiding this comment.
Added the comment to stringify().
Contributor
|
lgtm modulo nit on stringification. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the testharness adaptor dump the test failures on the window object for use in
grunt debug.It also outputs the failures formatted to be suitable for pasting into expectedFailures in web-platform-tests-expectations.js.
This patch builds upon #467.