Skip to content

Deprecate invalid timing inputs instead of throwing TypeErrors immediately #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alancutter merged 2 commits into from
Apr 28, 2016
Merged

Deprecate invalid timing inputs instead of throwing TypeErrors immediately #437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a67d7af
deprecatedTesting
alancutter Apr 28, 2016
b83173b
No double nesting
alancutter Apr 28, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/deprecation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@
var silenced = {};

shared.isDeprecated = function(feature, date, advice, plural) {
if (WEB_ANIMATIONS_TESTING) {
return true;
}

var auxVerb = plural ? 'are' : 'is';
var today = new Date();
var expiry = new Date(date);
Expand Down
12 changes: 8 additions & 4 deletions src/timing-utilities.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,10 @@
this._easingFunction = linear;
}

function isInvalidTimingDeprecated() {
return shared.isDeprecated('Invalid timing inputs', '2016-03-02', 'TypeError exceptions will be thrown instead.', true);
}

AnimationEffectTiming.prototype = {
_setMember: function(member, value) {
this['_' + member] = value;
Expand Down Expand Up @@ -76,7 +80,7 @@
return this._fill;
},
set iterationStart(value) {
if (isNaN(value) || value < 0) {
if ((isNaN(value) || value < 0) && isInvalidTimingDeprecated()) {
throw new TypeError('iterationStart must be a non-negative number, received: ' + timing.iterationStart);
}
this._setMember('iterationStart', value);
Expand All @@ -85,7 +89,7 @@
return this._iterationStart;
},
set duration(value) {
if (value != 'auto' && (isNaN(value) || value < 0)) {
if (value != 'auto' && (isNaN(value) || value < 0) && isInvalidTimingDeprecated()) {
throw new TypeError('duration must be non-negative or auto, received: ' + value);
}
this._setMember('duration', value);
Expand All @@ -107,7 +111,7 @@
return this._easing;
},
set iterations(value) {
if (isNaN(value) || value < 0) {
if ((isNaN(value) || value < 0) && isInvalidTimingDeprecated()) {
throw new TypeError('iterations must be non-negative, received: ' + value);
}
this._setMember('iterations', value);
Expand Down Expand Up @@ -228,7 +232,7 @@
styleForCleaning.animationTimingFunction = easing;
var validatedEasing = styleForCleaning.animationTimingFunction;

if (validatedEasing == '') {
if (validatedEasing == '' && isInvalidTimingDeprecated()) {
throw new TypeError(easing + ' is not a valid value for easing');
}

Expand Down