Skip to content

Add stroke-dashoffset handler #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suzyh merged 2 commits into from
Nov 22, 2016
Merged

Add stroke-dashoffset handler #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d190b
adding stroke dash offset handler
filaraujo Sep 19, 2016
a44a911
Add property-specific interpolation test
suzyh Nov 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/dimension-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@
'perspective',
'right',
'shape-margin',
'stroke-dashoffset',
'text-indent',
'top',
'vertical-align',
Expand Down
2 changes: 1 addition & 1 deletion src/property-interpolation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
paddingRight: '0px',
paddingTop: '0px',
right: 'auto',
strokeDashoffset: '0px',
textIndent: '0px',
textShadow: '0px 0px 0px transparent',
top: 'auto',
Expand Down Expand Up @@ -124,4 +125,3 @@
scope.propertyInterpolation = propertyInterpolation;

})(webAnimationsShared, webAnimations1, webAnimationsTesting);

4 changes: 4 additions & 0 deletions test/js/dimension-handler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,4 +71,8 @@ suite('dimension-handler', function() {
assert.isUndefined(webAnimations1.consumeLengthOrPercent('(10px)'));
assert.isUndefined(webAnimations1.consumeLengthOrPercent('calc(10px,10px)'));
});
test('interpolation of more specific properties', function() {
assert.equal(webAnimations1.propertyInterpolation('strokeDashoffset', '10px', '50px')(0.25), '20px');
Copy link
Contributor

@alancutter alancutter Nov 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be able to interpolate multi valued values e.g. '10px 20px' to '50px 60px'.
If it doesn't can you file an issue to add support for it? I won't block this patch on supporting that right away.

lgtm.

Copy link
Contributor Author

@suzyh suzyh Nov 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turns out stroke-dashoffset does not support multiple values; that's stroke-dasharray. Submitting as-is.

assert.equal(webAnimations1.propertyInterpolation('textIndent', '10px', '50px')(0.25), '20px');
});
});