adding stroke dash offset handler #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

filaraujo wants to merge 1 commit into web-animations:master from filaraujo:master

Contributor

filaraujo commented Sep 19, 2016

fixes stroke dash offset not animating correctly in older browsers #84


          adding stroke dash offset handler

b4e3461

filaraujo mentioned this pull request

Dashoffset not properly animating in ios 8.1 #84

Closed

Contributor

alancutter commented Sep 19, 2016

Thanks for the investigation and the patch!
A few things to alter before we can merge this:

Please submit this to the development repo https://github.com/web-animations/web-animations-next instead (no need to build the min files).
Include a test for your change (https://github.com/web-animations/web-animations-next/blob/master/test/js/dimension-handler.js is the appropriate place).
Make sure you've signed the Contributor License Agreement: https://cla.developers.google.com/about/google-individual

suzyh mentioned this pull request

Add stroke-dashoffset handler #96

Merged

Contributor

suzyh commented Nov 14, 2016

Closing in favour of #96. Thanks @filaraujo!

suzyh closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet