Minor fixes for Closure compilation compatibility.#200
Merged
Conversation
samthor
approved these changes
Dec 11, 2018
Contributor
Author
|
@samthor Getting the same set of Travis errors as the previous commit (https://travis-ci.org/web-animations/web-animations-js/builds/391957171?utm_source=github_status&utm_medium=notification). So, fairly sure it's not related to this PR. Let me know if you're ok to merge despite these errors. |
Contributor
|
Yes, that looks largely unrelated. |
Contributor
Author
|
Sounds good -- will you merge? I don't have the power. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes allow the Closure compiler to compile the web animations polyfill without errors (still a number of warnings, but not critical).