-
Notifications
You must be signed in to change notification settings - Fork 86
Close possibly open objects #985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge. |
@weaviate-git-bot I agree to the Contributor License Agreement |
This is a very simple change but looks complicated in the default diff view. After you enable Hide whitespace in the diff view settings on GitHub you will be able to view only the lines that were added and removed. |
HI @abhishek-compro , thanks for your contribution! There are some type-checking failures, could you please adress them? |
82e65df
to
b621c05
Compare
Done |
@dirkkul I have run the tests as per the contributing guide and it only gives some warnings but no errors. I am using version 1.24.1. I don't know how to fix address that is already in use. Is it something specific to my changes? |
that is sadly a flaky CI test, should not be connected to your changes Thanks for your contribution, merged :) |
This is mostly a refactor. Let me know if there are any conflicting opinions.