-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add group_by
parameter to bm25
and hybrid
#978
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also align return types of docstrings between all queries
…n-client into add-groupby-to-bm25-and-hybrid
group_by
parameter to bm25
and `hybridgroup_by
parameter to bm25
and hybrid
…n-client into add-groupby-to-bm25-and-hybrid
Great to see you again! Thanks for the contribution. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/1.25 #978 +/- ##
============================================
- Coverage 95.00% 94.83% -0.17%
============================================
Files 175 175
Lines 18022 18089 +67
============================================
+ Hits 17122 17155 +33
- Misses 900 934 +34 ☔ View full report in Codecov by Sentry. |
…n-client into add-groupby-to-bm25-and-hybrid
f4faec3
to
649e3de
Compare
dirkkul
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
core PR: weaviate/weaviate#4477