Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes error on calling cluster.nodes(output="verbose") on empty cluster #883

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ There are three kinds of tests:
To run the integration tests,

1. Ensure that you have Docker installed.
2. Start the weaviate instances.
2. Start the weaviate instances, changing `WEAVIATE_VERSION` to your weaviate docker image target

```shell
./ci/start_weaviate.sh
./ci/start_weaviate.sh WEAVIATE_VERSION
```

3. Run the tests.
Expand Down
2 changes: 0 additions & 2 deletions README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,6 @@ The client is tested for python 3.8 and higher.

Visit the official `Weaviate <https://weaviate.io/>`_ website for more information about the Weaviate and how to use it in production.

Check out our `Command Line Interface (CLI) tool <https://pypi.org/project/weaviate-cli/>`_ for interacting with a Weaviate instance directly from your Terminal.

Articles
--------

Expand Down
4 changes: 2 additions & 2 deletions weaviate/collections/classes/cluster.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,11 @@ def nodes_verbose(nodes: List[NodeREST]) -> List[Node[Shards, Stats]]:
object_count=shard["objectCount"],
)
for shard in cast(List[ShardREST], node["shards"])
],
] if "shards" in nodes else None,
stats=Stats(
object_count=node["stats"]["objectCount"],
shard_count=node["stats"]["shardCount"],
),
) if "stats" in node else None,
status=node["status"],
version=node["version"],
)
Expand Down
Loading