Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DR-118 readthedocs fixes #860

Merged
merged 9 commits into from
Feb 7, 2024

Conversation

daveatweaviate
Copy link
Contributor

@codecov-commenter
Copy link

Codecov Report

Attention: 265 lines in your changes are missing coverage. Please review.

Comparison is base (e977081) 93.48% compared to head (0d9d577) 95.51%.
Report is 102 commits behind head on main.

Files Patch % Lines
integration/test_collection_openai.py 41.25% 84 Missing ⚠️
weaviate/collections/batch/base.py 82.10% 51 Missing ⚠️
integration/test_collection_rerank.py 32.69% 35 Missing ⚠️
integration/test_batch_v4.py 95.08% 14 Missing ⚠️
integration_v3/test_backup_v4.py 92.76% 11 Missing ⚠️
mock_tests/test_collection.py 85.71% 10 Missing ⚠️
weaviate/collections/aggregations/base.py 94.57% 9 Missing ⚠️
weaviate/collections/batch/batch_wrapper.py 86.20% 8 Missing ⚠️
integration/conftest.py 88.52% 7 Missing ⚠️
integration/test_collection_aggregate.py 97.41% 7 Missing ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #860      +/-   ##
==========================================
+ Coverage   93.48%   95.51%   +2.02%     
==========================================
  Files          70      167      +97     
  Lines        8625    17138    +8513     
==========================================
+ Hits         8063    16369    +8306     
- Misses        562      769     +207     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@daveatweaviate daveatweaviate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dirkkul @tsmith023 This should fix the readthdocs page.

I'm not sure if it needs to be backported to earlier releases. If so, I'll do that tomorrow. Similarly, I don't see the versioin picker at the lower right of the ToC panel in my staging build. I think that might be an artifact though.

Once we push this, I'll check if on backporting and the version picker

docs/changelog.rst Show resolved Hide resolved
weaviate/collections/queries/base.py Show resolved Hide resolved
weaviate/warnings.py Show resolved Hide resolved
@dirkkul dirkkul merged commit 2a51e1d into main Feb 7, 2024
35 checks passed
@dirkkul dirkkul deleted the DR-118-update-py-4-client-docs-for-readthedocs branch February 7, 2024 14:24
@tsmith023
Copy link
Collaborator

I'm not sure if it needs to be backported to earlier releases

AFAIK, this is impossible since the builds are executed on the released GH tags that must be static and unchanging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants