Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to skip input parameter validation #854

Merged
merged 3 commits into from
Feb 5, 2024
Merged

Add option to skip input parameter validation #854

merged 3 commits into from
Feb 5, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Feb 5, 2024

No description provided.

@dirkkul dirkkul requested a review from a team as a code owner February 5, 2024 06:55
tsmith023
tsmith023 approved these changes Feb 5, 2024
View reviewed changes
Copy link
Collaborator

@tsmith023 tsmith023 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if self._validate_arguments is missing in:

  • collection.with_tenant
  • collections.delete
  • collections.exists
  • collections.list_all
  • data.exists
  • tenants.create
  • tenants.remove
  • tenants.update
  • Methods in aggregations/base.py

It could be that these aren't useful to cancel since they aren't high throughput methods?

@dirkkul dirkkul merged commit 12a2d54 into main Feb 5, 2024
35 checks passed
@dirkkul dirkkul deleted the skip_parameter_validation branch February 5, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsmith023 tsmith023 tsmith023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dirkkul @tsmith023