Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed connect helpers' documentation #840

Merged
merged 1 commit into from
Feb 1, 2024
Merged

fixed connect helpers' documentation #840

merged 1 commit into from
Feb 1, 2024

Conversation

SavvasMohito
Copy link
Contributor

connect_to_custom() and connect_to_local() still had the old timeout description in their function definitions. I replaced it with the new additional_config to match their input variables (similar to connect_to_wcs() and connect_to_embedded())

connect_to_custom() and connect_to_local() still had the old timeout description in their function definitions. I replaced it with the new additional_config to match their input variables (similar to connect_to_wcs() and connect_to_embedded())
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.10%. Comparing base (e977081) to head (558ccad).
Report is 1696 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #840      +/-   ##
==========================================
+ Coverage   93.48%   95.10%   +1.61%     
==========================================
  Files          70      166      +96     
  Lines        8625    17085    +8460     
==========================================
+ Hits         8063    16248    +8185     
- Misses        562      837     +275     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SavvasMohito
Copy link
Contributor Author

the test seems to fail because of this:
{"action":"grpc_startup","error":"listen tcp :50040: bind: address already in use","level":"fatal","msg":"failed to start grpc server","time":"2024-01-31T16:29:06Z"}

maybe a config issue with the test scripts?

@tsmith023
Copy link
Collaborator

Sadly, there are multiple flaky tests in our CI pipeline currently that we hope to iron out in the coming weeks

@weaviate-git-bot
Copy link

To avoid any confusion in the future about your contribution to Weaviate, we work with a Contributor License Agreement. If you agree, you can simply add a comment to this PR that you agree with the CLA so that we can merge.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@dirkkul dirkkul merged commit 1d147a0 into weaviate:main Feb 1, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants