Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support output verbosity option for nodes status getter #638

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

parkerduckworth
Copy link
Member

Client support for nodes API verbosity, introduced to weaviate core with this PR

@parkerduckworth parkerduckworth requested a review from a team as a code owner December 7, 2023 18:48
@codecov-commenter
Copy link

Codecov Report

Attention: 108 lines in your changes are missing coverage. Please review.

Comparison is base (7528726) 94.75% compared to head (92b8689) 93.58%.
Report is 84 commits behind head on main.

Files Patch % Lines
weaviate/proto/v1/search_get_pb2.py 10.66% 67 Missing ⚠️
weaviate/proto/v1/weaviate_pb2_grpc.py 10.71% 25 Missing ⚠️
weaviate/batch/crud_batch.py 70.27% 11 Missing ⚠️
weaviate/gql/get.py 25.00% 3 Missing ⚠️
weaviate/connect/connection.py 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #638      +/-   ##
==========================================
- Coverage   94.75%   93.58%   -1.18%     
==========================================
  Files          70       70              
  Lines        8492     8709     +217     
==========================================
+ Hits         8047     8150     +103     
- Misses        445      559     +114     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@dirkkul dirkkul merged commit e7f547f into main Dec 8, 2023
27 checks passed
@dirkkul dirkkul deleted the nodes-api-verbosity branch December 8, 2023 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants