Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new object dataTypes and write tests for them #570

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

tsmith023
Copy link
Collaborator

This PR adds the object and object[] data types to the allowed types when users define their schema. It then also provides a number of tests to ensure that the functionality from the client is as expected using these new data types.

@antas-marcin, please let me know if I'm missing any specific implementation with these data types that are not covered by the tests!

@tsmith023 tsmith023 requested a review from antas-marcin October 2, 2023 11:06
@tsmith023 tsmith023 requested a review from a team as a code owner October 2, 2023 11:06
@codecov-commenter
Copy link

Codecov Report

Attention: 104 lines in your changes are missing coverage. Please review.

Comparison is base (7528726) 94.75% compared to head (a69fa6c) 94.03%.
Report is 24 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #570      +/-   ##
==========================================
- Coverage   94.75%   94.03%   -0.73%     
==========================================
  Files          70       73       +3     
  Lines        8492     8663     +171     
==========================================
+ Hits         8047     8146      +99     
- Misses        445      517      +72     
Files Coverage Δ
integration/test_batch.py 98.54% <100.00%> (+0.10%) ⬆️
integration/test_cluster.py 100.00% <100.00%> (ø)
integration/test_crud.py 100.00% <100.00%> (ø)
integration/test_graphql.py 94.44% <100.00%> (+0.29%) ⬆️
integration/test_schema.py 97.54% <100.00%> (+0.17%) ⬆️
test/test_client.py 100.00% <100.00%> (ø)
test/test_embedded.py 97.77% <100.00%> (+0.21%) ⬆️
weaviate/client.py 98.66% <100.00%> (ø)
weaviate/connect/authentication.py 96.15% <100.00%> (ø)
weaviate/embedded.py 92.30% <100.00%> (+0.25%) ⬆️
... and 9 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 merged commit aaf5ec3 into main Oct 2, 2023
@tsmith023 tsmith023 deleted the support-nested-objects branch October 2, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants