-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/#486 #488
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #488 +/- ##
==========================================
- Coverage 95.43% 94.88% -0.55%
==========================================
Files 64 72 +8
Lines 8165 8668 +503
==========================================
+ Hits 7792 8225 +433
- Misses 373 443 +70
☔ View full report in Codecov by Sentry. |
Let's just remove the schema validation. It always causes problems and doesn't help much |
Great to see you again! Thanks for the contribution. |
Fixes #486 by checking whether
class_definition["properties"]
is notNone
before performing further schema checks