Skip to content

Remove cluster hostname from weaviate embedded #279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Mar 30, 2023

No description provided.

@dirkkul dirkkul requested a review from parkerduckworth March 30, 2023 15:20
@dirkkul dirkkul merged commit 3772061 into main Mar 31, 2023
@etiennedi
Copy link
Member

@dirkkul Won't this lead to not being able to start up an embedded setup again if your host name changes? (for example, because you changed wifis). Thought that was the reason why an explicit hostname was set?

@dirkkul
Copy link
Collaborator Author

dirkkul commented Mar 31, 2023

it's the cluster_hostname not the hostname

@etiennedi
Copy link
Member

Isn't that the same? I think we only have this one variable?

@dirkkul
Copy link
Collaborator Author

dirkkul commented Mar 31, 2023

It only affects this env variable: my_env.setdefault("CLUSTER_HOSTNAME", self.options.cluster_hostname). You can still set it via additional_env_vars if you need it for whatever reason.

(Not sure why that would be affected by a changed wifi)

@dirkkul dirkkul deleted the remove_hostname branch April 21, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants