Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dimensions param to text2vec_azure_openai #1508

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

tsmith023
Copy link
Contributor

Closes #1445

@tsmith023 tsmith023 requested a review from dirkkul January 10, 2025 17:43
Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (92588ed) to head (945740c).
Report is 48 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
- Coverage   90.12%   89.96%   -0.16%     
==========================================
  Files         175      182       +7     
  Lines       15055    15284     +229     
==========================================
+ Hits        13568    13751     +183     
- Misses       1487     1533      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@tsmith023 tsmith023 merged commit 6c1c995 into main Jan 14, 2025
25 of 36 checks passed
@tsmith023 tsmith023 deleted the #1445/add-dimensions-param-to-text2vec-azure-openai branch January 14, 2025 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dimension Parameter to Azure OpenAI Vectorizer Client
4 participants