Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dynamic backup path #1494

Merged
merged 6 commits into from
Jan 10, 2025
Merged

Add support for dynamic backup path #1494

merged 6 commits into from
Jan 10, 2025

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Dec 27, 2024

Adds support for dynamic paths in backups.

Create a dynamic path using wvc.backup.DynamicPath.BACKUP_MODULE(path=str(tmp_path))

For the **_status calls, there is a new option dynamic_path, which accepts the output of ⬆️
For create, restore and cancel the config option has a new dynamic_path entry and also accepts the output of ⬆️ directly

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed SAST high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.19298% with 26 lines in your changes missing coverage. Please review.

Project coverage is 90.01%. Comparing base (a373ee6) to head (60c8a73).
Report is 216 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/backup/backup.py 65.38% 18 Missing ⚠️
integration/test_backup_v4.py 81.81% 6 Missing ⚠️
weaviate/backup/dynamic_path.py 91.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1494      +/-   ##
==========================================
- Coverage   93.98%   90.01%   -3.98%     
==========================================
  Files         221      177      -44     
  Lines       21332    15146    -6186     
==========================================
- Hits        20048    13633    -6415     
- Misses       1284     1513     +229     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul requested a review from tsmith023 January 9, 2025 11:56
@dirkkul dirkkul merged commit 18838b1 into main Jan 10, 2025
35 of 39 checks passed
@dirkkul dirkkul deleted the dynamic_backup branch January 10, 2025 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants