Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix backup/restore for the embedded server #1485

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

parkerduckworth
Copy link
Member

This PR addresses improper internal port configuration at embedded DB startup. We received a user report (weaviate/weaviate#6570) that backups created with the embedded DB always fail.

I was able to reproduce this for all versions >= 1.25.0, indicating that this issue was somehow related to Raft (which was introduced in 1.25.0)

The wrongly-configured internal cluster communication ports resulted in the raft port for the node being set to the same port as the gossip protocol data_bind_port (which is used to transmit data from node to node). This caused all intra cluster comms to fail. We never noticed this before because the embedded DB does not support multi-node mode. However, backups are an edge case here, because all backups are treated as if they were distributed, so all backup comms require making requests to the intra cluster server.

So now this is fixed, and if we ever decide to support clustering for embedded DB, we are one step closer :)

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.03%. Comparing base (dee9f6b) to head (9d4f948).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1485      +/-   ##
==========================================
+ Coverage   89.94%   90.03%   +0.08%     
==========================================
  Files         174      174              
  Lines       14919    14940      +21     
==========================================
+ Hits        13419    13451      +32     
+ Misses       1500     1489      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weaviate-git-bot
Copy link

Great to see you again! Thanks for the contribution.

beep boop - the Weaviate bot 👋🤖

PS:
Are you already a member of the Weaviate Slack channel?

@dirkkul dirkkul merged commit 7b0a7e7 into main Dec 16, 2024
38 checks passed
@dirkkul dirkkul deleted the fix/embedded-backups branch December 16, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants