Fix backup/restore for the embedded server #1485
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses improper internal port configuration at embedded DB startup. We received a user report (weaviate/weaviate#6570) that backups created with the embedded DB always fail.
I was able to reproduce this for all versions >= 1.25.0, indicating that this issue was somehow related to Raft (which was introduced in 1.25.0)
The wrongly-configured internal cluster communication ports resulted in the raft port for the node being set to the same port as the gossip protocol
data_bind_port
(which is used to transmit data from node to node). This caused all intra cluster comms to fail. We never noticed this before because the embedded DB does not support multi-node mode. However, backups are an edge case here, because all backups are treated as if they were distributed, so all backup comms require making requests to the intra cluster server.So now this is fixed, and if we ever decide to support clustering for embedded DB, we are one step closer :)