Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new httpx versions #1474

Merged
merged 1 commit into from
Dec 12, 2024
Merged

Enable new httpx versions #1474

merged 1 commit into from
Dec 12, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Dec 12, 2024

proxies got removed in 0.28.0 and replaced with a combination of proxy (single proxy) and mounts (multi proxy). I just replaced everything with mounts. Minimum version with proxy is 0.26 which is now our new minimum version.

Copy link

@orca-security-eu orca-security-eu bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.93%. Comparing base (1efb556) to head (210b510).

Files with missing lines Patch % Lines
weaviate/connect/authentication_async.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
- Coverage   92.00%   91.93%   -0.08%     
==========================================
  Files         174      174              
  Lines       14912    14910       -2     
==========================================
- Hits        13720    13707      -13     
- Misses       1192     1203      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul merged commit 50ee18c into main Dec 12, 2024
41 checks passed
@dirkkul dirkkul deleted the update_httpx branch December 12, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants