Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multi2vec-jinaai; docstring changes #1422

Merged
merged 6 commits into from
Nov 20, 2024
Merged

Add support for multi2vec-jinaai; docstring changes #1422

merged 6 commits into from
Nov 20, 2024

Conversation

databyjp
Copy link
Contributor

@databyjp databyjp commented Nov 19, 2024 •
edited
Loading

  • Add support for multi2vec-jinaai module
  • Update model validation list for Cohere multi-modal models
  • Docstring changes to link to model provider integrations pages where applicable

orca-security-eu[bot]
orca-security-eu bot reviewed Nov 19, 2024
View reviewed changes
Copy link

@orca-security-eu orca-security-eu bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Infrastructure as Code high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@databyjp databyjp marked this pull request as ready for review November 20, 2024 08:01
@databyjp databyjp requested a review from tsmith023 November 20, 2024 08:01
@databyjp
Copy link
Contributor Author

Hi @tsmith023 note the core PR isn’t ready so there may be changes, but I thought I’d ask for a review first so we can have it ready. Ty!

@dirkkul
Copy link
Collaborator

dirkkul commented Nov 20, 2024

LGTM - please test it out once the module is ready and then just merge if everything works. Thank you!

@dirkkul dirkkul merged commit acf7c0d into main Nov 20, 2024
47 checks passed
@dirkkul dirkkul deleted the multi2vec-jinaai branch November 20, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orca-security-eu orca-security-eu[bot] orca-security-eu[bot] left review comments

@dirkkul dirkkul dirkkul approved these changes

@tsmith023 tsmith023 Awaiting requested review from tsmith023

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@databyjp @dirkkul