-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gracefully handle multiprocessing forks in _EventLoopSingleton
#1373
Conversation
…all in a different process
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1373 +/- ##
==========================================
- Coverage 94.38% 93.94% -0.44%
==========================================
Files 220 221 +1
Lines 20956 21283 +327
==========================================
+ Hits 19779 19995 +216
- Misses 1177 1288 +111 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test? :)
Great to see you again! Thanks for the contribution. |
Closes #1309
MRE to reproduce, courtesy of @gariel ❤️
and run:
gunicorn --bind=0.0.0.0:80 --workers=2 --worker-class "uvicorn.workers.UvicornWorker" --preload main:app