Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing tenant and consistency_level to collection/base.pyi #1327

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

tsmith023
Copy link
Collaborator

@tsmith023 tsmith023 commented Oct 8, 2024

Fixes missing type information for:

collection = client.collections.get(name)
tenant = collection.tenant

that would previously return Any for collection.tenant

@tsmith023 tsmith023 requested a review from dirkkul October 8, 2024 12:39
@dirkkul dirkkul merged commit d5ebd40 into main Oct 8, 2024
49 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.38%. Comparing base (624e2e2) to head (3f68082).
Report is 68 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1327   +/-   ##
=======================================
  Coverage   94.38%   94.38%           
=======================================
  Files         220      220           
  Lines       20953    20956    +3     
=======================================
+ Hits        19776    19779    +3     
  Misses       1177     1177           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul deleted the fix/add-missing-fields-to-collection-stub branch October 8, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants