Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cancel backups #1264

Merged
merged 10 commits into from
Oct 8, 2024
Merged

Add support for cancel backups #1264

merged 10 commits into from
Oct 8, 2024

Conversation

dirkkul
Copy link
Collaborator

@dirkkul dirkkul commented Aug 28, 2024

List backups has been moved back, but I'll leave the code that has already been written in there

@dirkkul dirkkul requested a review from a team as a code owner August 28, 2024 11:51
@dirkkul dirkkul marked this pull request as draft August 28, 2024 11:51
@dirkkul dirkkul changed the title Add support for list backups Add support for list and cancel backups Aug 29, 2024
weaviate/backup/backup.py Outdated Show resolved Hide resolved
@dirkkul dirkkul changed the base branch from dev/1.27 to main October 8, 2024 09:11
@dirkkul dirkkul changed the title Add support for list and cancel backups Add support for cancel backups Oct 8, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 44.18605% with 24 lines in your changes missing coverage. Please review.

Project coverage is 94.27%. Comparing base (624e2e2) to head (26da9be).
Report is 66 commits behind head on main.

Files with missing lines Patch % Lines
weaviate/backup/backup.py 37.03% 17 Missing ⚠️
integration_v3/test_backup_v4.py 41.66% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1264      +/-   ##
==========================================
- Coverage   94.38%   94.27%   -0.11%     
==========================================
  Files         220      220              
  Lines       20953    20993      +40     
==========================================
+ Hits        19776    19792      +16     
- Misses       1177     1201      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dirkkul dirkkul marked this pull request as ready for review October 8, 2024 10:54
integration_v3/test_backup_v4.py Show resolved Hide resolved
integration_v3/test_backup_v4.py Outdated Show resolved Hide resolved
weaviate/backup/backup.py Outdated Show resolved Hide resolved
weaviate/backup/backup.py Outdated Show resolved Hide resolved
weaviate/backup/backup.py Outdated Show resolved Hide resolved
weaviate/backup/backup.py Show resolved Hide resolved
@dirkkul dirkkul merged commit 51614e5 into main Oct 8, 2024
46 of 50 checks passed
@dirkkul dirkkul deleted the list_backups branch October 8, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants