Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tenants to use gRPC methods for get operations #1031

Merged
merged 15 commits into from
May 6, 2024

Conversation

tsmith023
Copy link
Collaborator

No description provided.

weaviate/collections/grpc/tenants.py Show resolved Hide resolved
weaviate/collections/grpc/tenants.py Outdated Show resolved Hide resolved
weaviate/collections/tenants.py Show resolved Hide resolved
weaviate/collections/tenants.py Outdated Show resolved Hide resolved
weaviate/collections/tenants.py Outdated Show resolved Hide resolved
weaviate/collections/tenants.py Show resolved Hide resolved
weaviate/collections/tenants.py Outdated Show resolved Hide resolved
weaviate/collections/tenants.py Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 22 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (dev/1.25@22b78a9). Click here to learn what that means.

Files Patch % Lines
weaviate/collections/grpc/tenants.py 80.00% 5 Missing ⚠️
weaviate/collections/tenants.py 86.48% 5 Missing ⚠️
integration/test_tenants.py 88.46% 3 Missing ⚠️
integration_v3/test_backup_v4.py 25.00% 3 Missing ⚠️
weaviate/backup/backup.py 50.00% 2 Missing ⚠️
weaviate/collections/collections.py 33.33% 2 Missing ⚠️
weaviate/exceptions.py 50.00% 1 Missing ⚠️
weaviate/util.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             dev/1.25    #1031   +/-   ##
===========================================
  Coverage            ?   94.96%           
===========================================
  Files               ?      176           
  Lines               ?    18096           
  Branches            ?        0           
===========================================
  Hits                ?    17184           
  Misses              ?      912           
  Partials            ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsmith023 tsmith023 requested a review from a team as a code owner April 30, 2024 17:56
weaviate/collections/grpc/tenants.py Outdated Show resolved Hide resolved
integration/test_tenants.py Show resolved Hide resolved
weaviate/collections/tenants.py Show resolved Hide resolved
@dirkkul dirkkul merged commit 7a3f8b6 into dev/1.25 May 6, 2024
42 of 43 checks passed
@dirkkul dirkkul deleted the 1.25/refactor-tenants-get-to-use-grpc branch May 6, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants