Skip to content

Commit

Permalink
Merge pull request #344 from weaviate/fix-release-step
Browse files Browse the repository at this point in the history
Fix adding of *.whl file to GitHub release
  • Loading branch information
antas-marcin authored May 29, 2023
2 parents d1d421f + 563d9cb commit bdc96d5
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
5 changes: 2 additions & 3 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,11 @@ jobs:
runs-on: ubuntu-latest
needs: [integration-tests, unit-tests, lint-and_format, build-and-add-artifact-and-publish]
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Download build artifact to append to release
uses: actions/download-artifact@v3
with:
path: "dist/*.whl"
name: weaviate-python-client-wheel
path: dist
- name: Release
uses: softprops/action-gh-release@v1
with:
Expand Down
8 changes: 5 additions & 3 deletions weaviate/gql/get.py
Original file line number Diff line number Diff line change
Expand Up @@ -1070,8 +1070,8 @@ def with_generate(
Parameters
----------
grouped_: Optional[str]
The task to generate a grouped response. One
grouped_task: Optional[str]
The task to generate a grouped response.
grouped_properties: Optional[List[str]]:
The properties whose contents are added to the prompts. If None or empty,
all text properties contents are added.
Expand All @@ -1095,7 +1095,9 @@ def with_generate(
if single_prompt is not None:
results.append("singleResult")
task_and_prompt += f'singleResult:{{prompt:"{util.strip_newlines(single_prompt)}"}}'
if grouped_task is not None:
if grouped_task is not None or (
grouped_properties is not None and len(grouped_properties) > 0
):
results.append("groupedResult")
args = []
if grouped_task is not None:
Expand Down

0 comments on commit bdc96d5

Please sign in to comment.