Typing fixes and add unsuported feature errors

weaviate · Jan 9, 2025 · aeb6557 · aeb6557
1 parent 76ad2d0
commit aeb6557
Showing 1 changed file with 32 additions and 3 deletions.
diff --git a/weaviate/backup/backup.py b/weaviate/backup/backup.py
@@ -171,7 +171,7 @@ async def create(
             "exclude": exclude_collections,
         }
 
-        if config is not None and isinstance(config, BackupConfigCreate):
+        if config is not None:
             if self._connection._weaviate_version.is_lower_than(1, 25, 0):
                 raise WeaviateUnsupportedFeatureError(
                     "BackupConfigCreate", str(self._connection._weaviate_version), "1.25.0"
@@ -183,6 +183,13 @@ async def create(
             payload["config"] = config._to_dict()
 
         if backup_location is not None:
+            if self._connection._weaviate_version.is_lower_than(1, 27, 2):
+                raise WeaviateUnsupportedFeatureError(
+                    "BackupConfigCreate dynamic backup location",
+                    str(self._connection._weaviate_version),
+                    "1.27.2",
+                )
+
             payload["config"].update(backup_location._to_dict())
 
         path = f"/backups/{backend.value}"
@@ -228,6 +235,13 @@ async def __get_create_status(
         path = f"/backups/{backend.value}/{backup_id}"
         params: Dict[str, str] = {}
         if backup_location is not None:
+            if self._connection._weaviate_version.is_lower_than(1, 27, 2):
+                raise WeaviateUnsupportedFeatureError(
+                    "BackupConfigCreateStatus dynamic backup location",
+                    str(self._connection._weaviate_version),
+                    "1.27.2",
+                )
+
             params.update(backup_location._to_dict())
 
         response = await self._connection.get(
@@ -330,7 +344,7 @@ async def restore(
             "exclude": exclude_collections,
         }
 
-        if config is not None and isinstance(config, BackupConfigRestore):
+        if config is not None:
             if self._connection._weaviate_version.is_lower_than(1, 25, 0):
                 raise WeaviateUnsupportedFeatureError(
                     "BackupConfigRestore", str(self._connection._weaviate_version), "1.25.0"
@@ -342,6 +356,13 @@ async def restore(
             payload["config"] = config._to_dict()
 
         if backup_location is not None:
+            if self._connection._weaviate_version.is_lower_than(1, 27, 2):
+                raise WeaviateUnsupportedFeatureError(
+                    "BackupConfigRestore dynamic backup location",
+                    str(self._connection._weaviate_version),
+                    "1.27.2",
+                )
+
             payload["config"].update(backup_location._to_dict())
 
         path = f"/backups/{backend.value}/{backup_id}/restore"
@@ -386,6 +407,12 @@ async def __get_restore_status(
 
         params: Dict[str, str] = {}
         if backup_location is not None:
+            if self._connection._weaviate_version.is_lower_than(1, 27, 2):
+                raise WeaviateUnsupportedFeatureError(
+                    "BackupConfigRestore status dynamic backup location",
+                    str(self._connection._weaviate_version),
+                    "1.27.2",
+                )
             params.update(backup_location._to_dict())
 
         response = await self._connection.get(
@@ -440,7 +467,9 @@ async def __cancel_backup(
         if backup_location is not None:
             if self._connection._weaviate_version.is_lower_than(1, 27, 2):
                 raise WeaviateUnsupportedFeatureError(
-                    "BackupConfigCancel", str(self._connection._weaviate_version), "1.27.2"
+                    "BackupConfigCancel dynamic backup location",
+                    str(self._connection._weaviate_version),
+                    "1.27.2",
                 )
             params.update(backup_location._to_dict())