Merge pull request #556 from weaviate/add-explicit-type-ignore-for-ty…

…peshed

Add `# type: ignore` instead of ignoring in `pyproject.toml`

.github/workflows/main.yaml

@@ -50,7 +50,7 @@ jobs:
           cache: 'pip' # caching pip dependencies
       - run: pip install -r requirements-devel.txt
       - name: Run mypy
-        run: mypy --python-version ${{matrix.version}} ${{ matrix.folder }}
+        run: mypy --warn-unused-ignores --python-version ${{matrix.version}} ${{ matrix.folder }}
 
   unit-tests:
     name: Run Unit Tests

pyproject.toml

@@ -36,16 +36,4 @@ exclude = ["weaviate_grpc", "docs", "mock_tests", "test", "integration"]
 
 [[tool.mypy.overrides]]
 module = "weaviate_grpc.*"
-ignore_errors = true
-
-[[tool.mypy.overrides]]
-module = "grpc.*"
-ignore_missing_imports = true
-
-[[tool.mypy.overrides]]
-module = "validators.*"
-ignore_missing_imports = true
-
-[[tool.mypy.overrides]]
-module = "authlib.integrations.requests_client.*"
-ignore_missing_imports = true
+ignore_errors = true

requirements-devel.txt

@@ -23,6 +23,7 @@ pytest-httpserver>=1.0.8
 mypy>=1.5.1<2.0.0
 mypy-extensions==1.0.0
 tomli>=2.0.1<3.0.0
+types-protobuf>=4.24.0.1<5.0.0
 types-requests>=2.31.0.2<3.0.0
 types-urllib3>=1.26.25.14<2.0.0
 typing_extensions>=4.7.1<5.0.0

weaviate/connect/authentication.py

@@ -4,7 +4,7 @@
 from typing import TYPE_CHECKING
 
 import requests
-from authlib.integrations.requests_client import OAuth2Session
+from authlib.integrations.requests_client import OAuth2Session  # type: ignore
 
 from weaviate.auth import (
     AuthCredentials,

weaviate/connect/connection.py

@@ -12,7 +12,7 @@
 from urllib.parse import urlparse
 
 import requests
-from authlib.integrations.requests_client import OAuth2Session
+from authlib.integrations.requests_client import OAuth2Session  # type: ignore
 from requests.adapters import HTTPAdapter
 from requests.exceptions import ConnectionError as RequestsConnectionError, ReadTimeout
 from requests.exceptions import HTTPError as RequestsHTTPError
@@ -39,7 +39,7 @@
 from weaviate.warnings import _Warnings
 
 try:
-    import grpc
+    import grpc  # type: ignore
     from weaviate_grpc import weaviate_pb2_grpc
 
     has_grpc = True

weaviate/embedded.py

@@ -15,7 +15,7 @@
 from typing import Dict, Optional
 
 import requests
-import validators
+import validators  # type: ignore
 
 from weaviate import exceptions
 from weaviate.exceptions import WeaviateStartUpError

weaviate/gql/get.py

@@ -39,7 +39,7 @@
 
 try:
     from weaviate_grpc import weaviate_pb2
-    import grpc
+    import grpc  # type: ignore
 except ImportError:
     pass
 

weaviate/util.py

@@ -11,7 +11,7 @@
 
 import requests
 import uuid as uuid_lib
-import validators
+import validators  # type: ignore
 from requests.exceptions import JSONDecodeError
 
 from weaviate.exceptions import (