Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update eslint config with react-hooks/exhaustive-deps rule for custom hooks #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update eslint config with react-hooks/exhaustive-deps rule for custom hooks #70

wants to merge 1 commit into from

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Dec 28, 2023 •
edited
Loading

Modify eslint config in backstage: https://backstage.io/docs/local-dev/cli-build-system/#linting

Add react-hooks/exhaustive-deps rule for additional hooks in eslint config: https://github.com/facebook/react/tree/main/packages/eslint-plugin-react-hooks#advanced-configuration

  • Fixed dependencies for custom hook which wasn't following the react-hooks/exhaustive-deps rules (useAsyncFn)

@AlinaGoaga AlinaGoaga marked this pull request as ready for review December 28, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[backstage] Investigate why eslint doesn't alert about hooks dependency errors
1 participant
@AlinaGoaga