This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Terminate NPC application if any of the watches panic #3841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than exiting silently, fetch the stack trace and print that for the user to understand what happened. Exit via existing fatal-error code.
bboreham
force-pushed
the
fail-controller-if-goroutines-fail
branch
from
cef8a63 to
4795ba5
Compare
|
thanks @bboreham . I've been out of the country for a while. 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #3792, rebased, squashed to remove back-steps, with a couple more commits to improve error reporting and remove an unnecessary variable.
Fixes #3764
Credit to @naemono
Work-around for kubernetes/client-go#838 / kubernetes/kubernetes#93641