Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

make DNS listen address properly configurable #1770

Closed
rade opened this issue Dec 9, 2015 · 0 comments · Fixed by #3231
Closed

make DNS listen address properly configurable #1770

rade opened this issue Dec 9, 2015 · 0 comments · Fixed by #3231
Labels
[component/dns] feature
Milestone
2.7

Comments

@rade
Copy link
Member

rade commented Dec 9, 2015

as an enabler to #1301...

The weave script and proxy should

  • pay attention to any --dns-listen-address passed in on weave launch, and use that instead of the docker bridge ip for configuring the DNS server
  • obtain the DNS listening address from weave (via an HTTP call, just as we do for the domain) when configuring the resolver of containers and running weave dns-lookup, instead of always using the docker bridge ip

And we should document --dns-listen-address.
@rade rade modified the milestones: 1.7.0, 1.8.0 Jun 25, 2016
@awh awh modified the milestones: 1.7.0, 1.8.0 Sep 23, 2016
@awh awh modified the milestones: 1.8.0, overflow Oct 7, 2016
This was referenced May 19, 2017
Closed
Closed
@weaveworks weaveworks deleted a comment from gucki Dec 9, 2017
@weaveworks weaveworks deleted a comment from rade Dec 9, 2017
@weaveworks weaveworks deleted a comment from gucki Dec 9, 2017
@bboreham bboreham mentioned this issue Dec 9, 2017
Merged
brb added a commit that referenced this issue Jan 29, 2018
@brb
Merge pull request #3196 from /issues/1770-proxy-dns-address
f66b0cc 
Make proxy use configured WeaveDNS address
@bboreham bboreham mentioned this issue Jan 29, 2018
Merged
bboreham added a commit that referenced this issue Jul 31, 2020
@bboreham
Merge pull request #3231 from /issues/1770-fetch-dns-address
cdbc25d 
 Fetch DNS listen address from daemon
@bboreham bboreham modified the milestones: overflow, 2.7 Aug 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
[component/dns] feature
Projects
None yet
Milestone
2.7
Development

Successfully merging a pull request may close this issue.

Fetch DNS listen address from daemon weaveworks/weave
3 participants
@rade @awh @bboreham