Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: reusable workflow for build-push image #4491

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Jan 12, 2025

Closes

What changed?

This deduplicates the image build jobs for CI/PR and release.

Why was this change made?

Duplication is something we should try to avoid, but in this case it's even more important: I want to add image signing to the (existing) release workflow.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb force-pushed the reusable-build-push-image branch 3 times, most recently from 31d0af2 to cbea988 Compare January 12, 2025 10:01
@erikgb erikgb requested review from casibbald and tenstad January 12, 2025 10:09
@erikgb erikgb marked this pull request as ready for review January 12, 2025 10:09
@erikgb erikgb force-pushed the reusable-build-push-image branch from cbea988 to e10c4a4 Compare January 12, 2025 11:20
@erikgb erikgb enabled auto-merge (rebase) January 12, 2025 11:21
@erikgb erikgb merged commit 7c0b690 into weaveworks:main Jan 12, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants