Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jest-fail-on-console #4286

Merged
merged 2 commits into from
Dec 29, 2024
Merged

Conversation

tenstad
Copy link
Contributor

@tenstad tenstad commented Dec 28, 2024

What changed?

Fixes jest-fail-on-console, as it does not work without setup
See https://github.com/ValentinH/jest-fail-on-console?tab=readme-ov-file#how-to-use

Why was this change made?

How was this change implemented?

How did you validate the change?

Added console.error in a test, with and without the setup.

Release notes

Documentation Changes

@tenstad tenstad force-pushed the fix-jest-fail-on-console branch from 42c2469 to e2a5e2e Compare December 28, 2024 16:14
@casibbald casibbald merged commit 53d5512 into weaveworks:main Dec 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants