Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hr related message appearing on ks #4066

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix hr related message appearing on ks #4066

merged 2 commits into from
Oct 4, 2023

Conversation

AlinaGoaga
Copy link
Contributor

@AlinaGoaga AlinaGoaga commented Oct 4, 2023 •
edited by enekofb
Loading

Closes #4057

Closes #4057

@AlinaGoaga AlinaGoaga marked this pull request as ready for review October 4, 2023 14:31
@AlinaGoaga AlinaGoaga requested review from makkes and foot October 4, 2023 14:33
foot
foot approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@foot foot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 !

@AlinaGoaga AlinaGoaga merged commit 006ed40 into main Oct 4, 2023
@AlinaGoaga AlinaGoaga deleted the speckubeconfig-bug branch October 4, 2023 16:13
@weave-gitops-bot weave-gitops-bot mentioned this pull request Oct 11, 2023
Merged
@weave-gitops-bot weave-gitops-bot mentioned this pull request Jan 2, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foot foot foot approved these changes

@makkes makkes Awaiting requested review from makkes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Message "spec.Kubeconfig is set on this HelmRelease" shows on Kustomizations
2 participants
@AlinaGoaga @foot