just my grain of salt of the pr

Signed-off-by: Eneko Fernandez <[email protected]>
weaveworks · Dec 19, 2023 · d1e38cf · d1e38cf
1 parent 96d19f0
commit d1e38cf
Showing 1 changed file with 6 additions and 8 deletions.
diff --git a/ui/App.tsx b/ui/App.tsx
@@ -67,21 +67,20 @@ function withSearchParams(Cmp) {
   };
 }
 
-// gets the right runtime navigation item based on the feature WEAVE_GITOPS_FEATURE_GITOPS_RUNTIME
-function getRuntimeConfiguration(isNewRuntimeEnabled: boolean): NavItem {
+function getRuntimeNavItem(isNewRuntimeEnabled: boolean): NavItem {
   if (isNewRuntimeEnabled) {
     return {
       label: "Runtime",
       link: { value: V2Routes.Runtime },
       icon: IconType.FluxIcon,
-    }
+    };
   }
 
   return {
     label: "Flux Runtime",
     link: { value: V2Routes.FluxRuntime },
     icon: IconType.FluxIcon,
-  }
+  };
 }
 
 const App = () => {
@@ -95,8 +94,6 @@ const App = () => {
   console.log("WEAVE_GITOPS_FEATURE_GITOPS_RUNTIME:")
   console.log(isNewRuntimeEnabled)
 
-  const runtimeNavItem: NavItem = getRuntimeConfiguration(isNewRuntimeEnabled);
-
   const navItems: NavItem[] = [
     {
       label: "Applications",
@@ -118,12 +115,13 @@ const App = () => {
       link: { value: V2Routes.Policies },
       icon: IconType.PoliciesIcon,
     },
-    runtimeNavItem,
+    getRuntimeNavItem(isNewRuntimeEnabled),
     {
       label: "Notifications",
       link: { value: V2Routes.Notifications },
       icon: IconType.NotificationsIcon,
-    }];
+    },
+  ];
 
   const [collapsed, setCollapsed] = React.useState<boolean>(false);
   const { currentPage } = useNavigation();