Add ARM64 build #3537
Add ARM64 build #3537
Conversation
bboreham
left a comment
bboreham
left a comment
There was a problem hiding this comment.
Thanks! One question below.
| curl -fsSLO https://download.docker.com/linux/static/stable/aarch64/docker-${DOCKERVERSION}.tgz && \ | ||
| tar xzvf docker-${DOCKERVERSION}.tgz --strip 1 -C /usr/local/bin docker/docker && \ | ||
| rm docker-${DOCKERVERSION}.tgz; \ | ||
| else \ |
There was a problem hiding this comment.
Can we special-case amd64 too, so if you build on something else you get an error and you know you have to fix it?
There was a problem hiding this comment.
Sure, will update the PR. BTW, I had to bump the Docker client version a bit since the previous used version was not built for ARM.
backend/Dockerfile
Outdated
| curl -fsSLO https://download.docker.com/linux/static/stable/x86_64/docker-${DOCKERVERSION}.tgz && \ | ||
| tar xzvf docker-${DOCKERVERSION}.tgz --strip 1 -C /usr/local/bin docker/docker && \ | ||
| rm docker-${DOCKERVERSION}.tgz; \ | ||
| fi; |
There was a problem hiding this comment.
I was expecting some kind of "else error" here, otherwise the failure mode is quite obscure.
|
Oops, sorry. I messed up with a merge. Will fix the branch. |
|
Fixed! |
|
@bboreham Is it possible to add the ARM image build to the CI? I see you guys use Circle-CI but I'm not versed on it. I could take a look tho. Dunno if Circle have multi-arch infrastructure for this but Weave Net already builds multi-arch images and manifests. |
|
Sadly the status of Weave Net is I run the final release build by hand because it didn't work on CircleCI. |
|
It will be very helpful if ARM64 image is released as ARM64 support has already been added. May I know when are you planning to release an ARM64 image? |
|
Happy to review a PR. |
3 participants
Actually I don't know how to add to the current PR #3372 (sorry) so I submitted this.
I can confirm that it builds and works perfectly on ARM64 in my current cluster: https://twitter.com/carlosedp/status/1073218995321483264
I'm currently building the ARM64 images and pushing them into my DockerHub account: https://hub.docker.com/r/carlosedp/scope