Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add touchpoints #925

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Add touchpoints #925

merged 2 commits into from
Mar 28, 2024

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

Adds the Touchpoints script. If we should be using a different form, we'll need to update this URL. Here's the form I created, with @sarahmhgov and I as form managers:

https://touchpoints.app.cloud.gov/admin/forms/22acf675

closes #913

Questions for Sarah

  • I used the "blue button and modal" option. We don't have much control over the button except for the text. It shows up at the far bottom right. Is that okay, or should we use one of the other options?

What does the reviewer need to know? 🤔

Screenshots (if appropriate): 📸

image

image

@eric-gade
Copy link
Collaborator

The button action and modal are working for me here no problem. I assume the form itself should not be working locally, however, because it requires some kind of credentials/token? I'm getting a CSRF invalid token error when trying to submit a message

@greg-does-weather
Copy link
Collaborator Author

Correct. The form will only work on beta.weather.gov. We have control over where it's allowed to come from, and for now I opted to restrict it.

Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a technical perspective, this is good to go. Needs a rebase though, and some accessibility tests are failing that I don't quite understand

@greg-does-weather
Copy link
Collaborator Author

The accessibility test errors are related to Touchpoints. Holding this PR for a couple days to see if they have tips on how to resolve them, or so we can decide on a workaround.

Slack thread

@greg-does-weather greg-does-weather added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit f69443b Mar 28, 2024
10 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/913-touchpoints branch March 28, 2024 14:13
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Touchpoints CTA and Form
2 participants