Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace h4 with h4-styled paragraph #600

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

Remove the <h4> element from the prototype alert component and replaces it with an h4-styled paragraph element. This fixes the heading ordering.

Closes #599

What does the reviewer need to know? 🤔

make cc

Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary component, so I'll forego the big list (checks are passing)

@greg-does-weather greg-does-weather added this pull request to the merge queue Jan 8, 2024
Merged via the queue into main with commit d99ae8f Jan 8, 2024
8 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/599-misordered-headings branch January 8, 2024 16:24
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prototype alerts create a misordered heading
2 participants