Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unnecessary fields in the weather narrative content type #542

Merged
merged 2 commits into from
Dec 15, 2023

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

  • Adds a new admin theme that derives from the Claro theme (our current default)
  • Sets the admin theme to our new one
  • Adds a hook to our new theme to remove the menu configuration and revision information panels from the weather narrative creation page
  • Updates the content type configuration to hide additional fields:
    • "Published" checkbox - it will just always be enabled for now (scheduling will be a separate body of work)
    • Tags
    • URL aliases
    • Front-page promotion
    • Authoring information (we will derive this from the logged-in user)
  • Limits the body input type to basic HTML, so there's no dropdown box for users to choose their type

What does the reviewer need to know? 🤔

You'll need to import config. That should be it.

Screenshots (if appropriate): 📸

Screenshot 2023-12-14 at 15-09-51 Create Weather narrative Weather gov

@greg-does-weather
Copy link
Collaborator Author

Converting to draft. Using this as the admin theme causes some stuff to disappear. Gonna have to look into it.

@greg-does-weather
Copy link
Collaborator Author

Found the issue. Theme regions and block placement are not inherited from base themes, because shut up, that's why.

@greg-does-weather greg-does-weather marked this pull request as ready for review December 14, 2023 22:39
Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Code Review Checklist

This is an automated comment on every pull request requiring a review. A checked item is either an assertion that I have tested this item or an indication that I have verified it does not apply to this pull request.

The Basics

  • Checks are passing
  • I read the code
  • I ran the code
  • (if applicable) Post deploy steps are run
  • (if applicable) I validated the change on the deployed version in

Documentation

  • changes to “how we do things” are documented in READMEs
  • all new functions and methods are commented using plain language
  • any new modules added documented in modules.md

Security

  • security false positives are documented
  • data from external sources is cleaned and clearly marked

Reliability

  • error handling exists for unusual or missing values
  • interactions with external systems are wrapped in try/except
  • functionality is tested with unit or integration tests
  • dependency updates in composer.json also got changed in composer-lock.json

Infrastructure

  • all changes are auditable and documented via a script
  • it is clear who can and should run the script
  • (if applicable) diagrams have been updated or added in PlantUML

Accessibility

  • New pages have been added to cypress-axe file so that they will be tested with or automated accessibility testing
  • Meets WCAG 2.0 AA or 2.1 AA for Section 508 compliance
    • Site is keyboard accessible. All interactions can be accessed with a keyboard
    • Site is free of keyboard traps. The keyboard focus is never trapped in a loop
    • All form inputs have explicit labels
    • Form instructions are associated with inputs
    • All relevant images use an img tag
    • All images have appropriate alt attributes
    • Multimedia is tagged. All multimedia has appropriate captioning and audio description
    • Text has sufficient color contrast. All text has a contrast ratio of 4.5:1 with the background
    • Site never loses focus. Focus is always visible when moving through the page with the keyboard
    • Tab order is logical
    • Tables are coded properly. Tables have proper headers and column attributes
    • Headings are nested properly. Heading elements are nested in a logical way
    • Language is set. The language for the page is set
    • CSS is not required to use the page. The page makes sense with or without CSS
    • Links are unique and contextual. All links can be understood taken alone, e.g., ‘Read more - about 508’
    • Page titles are descriptive

Device Matrix

  • firefox/gecko (renders correctly and user interactions work)
  • chrome/chromium/edge (renders correctly and user interactions work)
  • safari/webkit (renders correctly and user interactions work)
  • web page is readable and usable
    • at 480px (mobile)
    • at 640px (tablet)
    • at 1024px (desktop)

@greg-does-weather greg-does-weather added this pull request to the merge queue Dec 15, 2023
Merged via the queue into main with commit 6153cc3 Dec 15, 2023
8 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/486-weather-story-admin branch December 15, 2023 18:49
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants