Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add top margin to footer #528

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add top margin to footer #528

merged 1 commit into from
Dec 13, 2023

Conversation

greg-does-weather
Copy link
Collaborator

@greg-does-weather greg-does-weather commented Dec 12, 2023 •
edited
Loading

What does this PR do? 🛠️

What does the reviewer need to know? 🤔

Only needs a make cc

Screenshots

Screen Shot 2023-12-12 at 15 30 41

eric-gade
eric-gade approved these changes Dec 13, 2023
View reviewed changes
Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- good reorganization too

@greg-does-weather greg-does-weather added this pull request to the merge queue Dec 13, 2023
Merged via the queue into main with commit 293d276 Dec 13, 2023
8 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/527-footer-margin branch December 13, 2023 22:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-gade eric-gade eric-gade approved these changes

@shadkeene shadkeene Awaiting requested review from shadkeene

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add buffer between text box and footer
2 participants
@greg-does-weather @eric-gade