alter json api routes to require role: uploader #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-does-weather
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
This is a really clean solution. I love it!
One small question, and up to you whether you want to do anything with it. Would it make sense to move this into the weather_cms module instead of the weather_login module? Code organization is a neverending, unsolvable problem so there's no right answer. We also have weather_routes that might make sense? We should probably get together as a team and define some basic boundaries for these modules, so we have a shared understanding of what they’re for and what kinds of things go in them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
Alters the route such that the role
uploaderis required to access resources. Addresses #1659 -- we can still preventGETbut I'm feeling happier about this approach.What does the reviewer need to know? 🤔
Note: depends on the previous JSON API PR