-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AFD Styling #1621
AFD Styling #1621
Conversation
Co-authored-by: Igor Korenfeld <[email protected]>
Co-authored-by: Igor Korenfeld <[email protected]>
Co-authored-by: Igor Korenfeld <[email protected]>
1c7f382
to
3dcd237
Compare
This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file? |
This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR modifies theme Javascript or CSS assets but does not update the theme libraries file. Did you mean to update the appropriate version information in the libraries file? |
What does this PR do? 🛠️
This PR implements the styling specified in #1527 and probably #1530
### READ BEFORE MERGING! ###This branch is itself branched from
eg-1528-afd-html-endpoint
, which as of this writing is currently subject to an open PR #1587. That PR needs to be merged into main before we can merge this one in. I would prefer that, once the other PR is merged, we rebase this branch and force push (otherwise it might junk up the history). But either way, it is a prerequisite.Done!
What does the reviewer need to know? 🤔
Sticking with basic HTTP server requests / adding submit button
It was with this PR and related tickets that we have decided, for now, to stick with basic server-side/form based HTTP requests for updating the WFO selector and AFD version selector. Because of this, we called an audible and added a submit button that is not present in the original design Figma.
Parsed TEMPS/POPS table
Because it seemed like low hanging fruit, we have made an initial pass at parsing the (sometimes present) TEMPS/POPS table from raw text into an actual semantic html table. This can be iterated upon in the future.
Lack of cycling header
We have not yet included the "cycling header" from the Figma design. This is for a couple of reasons:
We have captured the need for implementing this component in this issue.
Screenshots (if appropriate): 📸
Desktop:
Mobile: