Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set admin favicon to site favicon #1614

Merged
merged 3 commits into from
Aug 26, 2024
Merged

Conversation

jamestranovich-noaa
Copy link
Collaborator

What does this PR do? 🛠️

This is a pet peeve of mine, but this PR changes the admin favicon. When browsing Drupal documentation, having the same default Drupal favicon as the admin site is confusing and makes it hard for me to find the right admin tab. Also added myself as a contributor.

Copy link
Collaborator

@greg-does-weather greg-does-weather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hell yeah

Also, apologies for not adding you to the contributors list from the start!

Copy link
Collaborator

@greg-does-weather greg-does-weather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. I only commented. Meant to approve. 🤦‍♂️

@greg-does-weather greg-does-weather merged commit 33a2f82 into main Aug 26, 2024
16 of 17 checks passed
@greg-does-weather greg-does-weather deleted the jt/admin-favicon-fix branch August 26, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants