-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docker: set www-data uid/gid to host's uid/gid #1583
Conversation
@@ -60,9 +67,6 @@ RUN set -eux; \ | |||
|
|||
COPY --from=composer:lts /usr/bin/composer /usr/local/bin/ | |||
|
|||
# https://www.drupal.org/node/3060/release | |||
ENV DRUPAL_VERSION 10.2.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this env setting is not needed (and is out of date, besides)
@@ -17,7 +17,7 @@ services: | |||
context: ./tests/api | |||
dockerfile: Dockerfile | |||
environment: | |||
WX_NOW_TIMESTAMP: ${WX_NOW_TIMESTAMP} | |||
WX_NOW_TIMESTAMP: ${WX_NOW_TIMESTAMP:-} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when we specify a blank default, this silences WX_NOW_TIMESTAMP variable is not set
warnings
ef7ee26
to
d47d9a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This doesn't break anything as far as I can tell.
It doesn't seem to fix the settings file permissions bug though (I was hoping it might as a bonus)
Code Review Checklist
This is an automated comment on every pull request requiring a review. A checked item is either an assertion that I have tested this item or an indication that I have verified it does not apply to this pull request.
The Basics
- Checks are passing
- I read the code
- I ran the code
- (if applicable) Post deploy steps are run
- (if applicable) I validated the change on the deployed version in
Documentation
- changes to “how we do things” are documented in READMEs
- all new functions and methods are commented using plain language
- any new modules added documented in modules.md
Security
- security false positives are documented
- data from external sources is cleaned and clearly marked
Reliability
- error handling exists for unusual or missing values
- interactions with external systems are wrapped in try/except
- functionality is tested with unit or integration tests
- dependency updates in composer.json also got changed in composer-lock.json
Infrastructure
- all changes are auditable and documented via a script
- it is clear who can and should run the script
- (if applicable) diagrams have been updated or added in PlantUML
Accessibility
- New pages have been added to cypress-axe file so that they will be tested with our automated accessibility testing
- Meets WCAG 2.0 AA or 2.1 AA for Section 508 compliance
- Site is keyboard accessible. All interactions can be accessed with a keyboard
- Site is free of keyboard traps. The keyboard focus is never trapped in a loop
- All form inputs have explicit labels
- Form instructions are associated with inputs
- All relevant images use an img tag
- All images have appropriate alt attributes
- Multimedia is tagged. All multimedia has appropriate captioning and audio description
- Text has sufficient color contrast. All text has a contrast ratio of 4.5:1 with the background
- Site never loses focus. Focus is always visible when moving through the page with the keyboard
- Tab order is logical
- Tables are coded properly. Tables have proper headers and column attributes
- Headings are nested properly. Heading elements are nested in a logical way
- Language is set. The language for the page is set
- CSS is not required to use the page. The page makes sense with or without CSS
- Links are unique and contextual. All links can be understood taken alone, e.g., ‘Read more - about 508’
- Page titles are descriptive
Device Matrix
- firefox/gecko (renders correctly and user interactions work)
- chrome/chromium/edge (renders correctly and user interactions work)
- safari/webkit (renders correctly and user interactions work)
- web page is readable and usable
- at 480px (mobile)
- at 640px (tablet)
- at 1024px (desktop)
d47d9a4
to
09489c2
Compare
09489c2
to
a10ebd9
Compare
What does this PR do? 🛠️
Attempts to fix internal docker permissions with respect to Drupal.
What does the reviewer need to know? 🤔
I suggest doing a clean git clone, checking out this branch, and then building. Otherwise, you might need to
git clean -fxd
to remove extant files with mangled permissions.To test:
make php-format
or try to upload a file. Shouldn't be any weird permission issues.