Initial AFD route, template, and bundle #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-gade
force-pushed
the
eg-1525-initial-afd-page
branch
2 times, most recently
from
7994883
to
5e74996
Compare
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.14.12 to 22.1.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
-- What When it comes to standard routes, Drupal attempts to cache the response _even if_ a querystring param has changed in the incoming URL.
Co-authored-by: Greg Walker <[email protected]>
eric-gade
force-pushed
the
eg-1525-initial-afd-page
branch
from
5e74996
to
d195614
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
This PR implements #1525, specifically:
/afd?wfo=querystring on the route/afd) or the latest AFD from a specific office (/afd?wfo=ETC)Note that per the ticket, we are keeping the formatting of the AFD body for the moment. Parsing will be in the next chunk of work.
What does the reviewer need to know? 🤔
Bundler changes
We've also updated the proxy/bundler, so that it can appropriately read, display, and provide information about Products from the API (including AFDs). There is new sample data that has been lightly edited that is available in this PR.
Testing
There are no e2e/browser tests yet, because subsequent tickets will change the structure of the AFD data and page templates dramatically as we move through the parent task.
Screenshots (if appropriate): 📸