Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wind speed behavior #1537

Merged
merged 2 commits into from
Aug 12, 2024
Merged

Update wind speed behavior #1537

merged 2 commits into from
Aug 12, 2024

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

  • removes the wind direction arrow if the wind speed is zero
  • replaces the "0 mph" with the word "calm" if the wind speed is zero

closes #1518

Screenshots (if appropriate): 📸

null wind
zero wind
some wind

eric-gade
eric-gade approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@greg-does-weather greg-does-weather merged commit c1b88d4 into main Aug 12, 2024
17 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/1518-wind-arrow branch August 12, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-gade eric-gade eric-gade approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wind arrow direction is displayed even when wind speed is zero
2 participants
@greg-does-weather @eric-gade