Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty alt text to satellite image #1516

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

#1310 added satellite imagery to the "current" tab. The satellite imagery should be hidden from assistive technology because it has the aria-hidden attribute; however, we should also set the alt attribute for technologies to fall back on if they don't support aria-hidden. This PR does that.

This PR also puts the "current" tab back into our accessibility testing flow. It fell out by accident when the tab was renamed from "today" to "current."

Copy link
Collaborator

@partly-igor partly-igor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@greg-does-weather greg-does-weather merged commit 049c46e into main Aug 1, 2024
16 of 17 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/satellite-alt-text branch August 1, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants