-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support redirecting from URLs with place names #1514
Conversation
e237a18
to
dedca9a
Compare
I think we're holding this for now. Is that right, @colinmurphy01? |
Yea, this was an idea. I'd love for @kmranjo to weigh in on the strategy here a little more and if we need a second opinon, we can bring in my supe. |
One thing I'll note is that by doing this, we could conceivably add all of the ~22,000 places in our database to our sitemap so search engines can find them. We cannot realistically add all of the grid points to a sitemap. |
Having readable place names in the URL can certainly help with SEO, but I don't think its make or break if there are drawbacks. I'm also not sure how we would do places that aren't as simple as state/city. Things like counties, mountains, etc where lat/long points might work better? |
This conversation really intrigues me because I don't see any downside to adding this. Whether it serves SEO value and whether/how we extend it to support other place types, it only seems like a net good. The code to support it is tiny and easy to maintain. I'm not gonna make a stink about it or anything, to be clear. I'm fine with letting it ripen, I'm just not clear on how it's unripe. 😂 |
Appreciate the nudge. In summary:
If that's the case, let's deploy it. Any objections? |
What does this PR do? 🛠️
Adds a new
/place/{state}/{city}
route. We look the state/city up in our places database and then redirect to the lat/lon URL.