Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support redirecting from URLs with place names #1514

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

Adds a new /place/{state}/{city} route. We look the state/city up in our places database and then redirect to the lat/lon URL.

@greg-does-weather
Copy link
Collaborator Author

I think we're holding this for now. Is that right, @colinmurphy01?

@colinmurphy01
Copy link
Collaborator

Yea, this was an idea. I'd love for @kmranjo to weigh in on the strategy here a little more and if we need a second opinon, we can bring in my supe.

@greg-does-weather greg-does-weather marked this pull request as draft August 7, 2024 17:22
@greg-does-weather
Copy link
Collaborator Author

One thing I'll note is that by doing this, we could conceivably add all of the ~22,000 places in our database to our sitemap so search engines can find them. We cannot realistically add all of the grid points to a sitemap.

@kmranjo
Copy link
Collaborator

kmranjo commented Aug 7, 2024

Having readable place names in the URL can certainly help with SEO, but I don't think its make or break if there are drawbacks. I'm also not sure how we would do places that aren't as simple as state/city. Things like counties, mountains, etc where lat/long points might work better?

@greg-does-weather
Copy link
Collaborator Author

This conversation really intrigues me because I don't see any downside to adding this. Whether it serves SEO value and whether/how we extend it to support other place types, it only seems like a net good. The code to support it is tiny and easy to maintain.

I'm not gonna make a stink about it or anything, to be clear. I'm fine with letting it ripen, I'm just not clear on how it's unripe. 😂

@colinmurphy01
Copy link
Collaborator

Appreciate the nudge.

In summary:

  • it'll improve SEO
  • it's easy to maintain and expand if needed
  • low-no risk in implementing now

If that's the case, let's deploy it. Any objections?

CC @coreypieper @shadkeene

@greg-does-weather greg-does-weather marked this pull request as ready for review August 19, 2024 13:15
@greg-does-weather greg-does-weather merged commit 92e9e93 into main Aug 19, 2024
16 of 17 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/redirect-place-name branch August 19, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants