Rely on Playwright's built-in tools for downloading browsers #1496
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-does-weather
requested review from
loganmcdonald-noaa and
eric-gade
and removed request for
loganmcdonald-noaa
eric-gade
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
Playwright's built-in tooling fetches browsers for us. I don't know why we added the
setup-browserstep, but getting rid of it and re-enabling MS Edge, tests go back to working.Spiritual reversion of #1461
What does the reviewer need to know? 🤔
The only way I know to verify what browsers were tested is to download the test report and visually verify that MS Edge is in the report.