WFO Information content type #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like our enabled modules has changed in this PR. Please ensure any documentation in https://github.com/weather-gov/weather.gov/tree/main/docs/dev/contributed-modules.md has been updated! |
kmranjo
approved these changes
Jul 30, 2024
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? 🛠️
This PR implements #1469, the creation of a new content-type called WFO Information. This content type will eventually supersede the WFO Promo type.
The changes are mostly config changes.
What does the reviewer need to know? 🤔
WFO Promo type lives! (for now)
In order to make the transition smoothly, we decided to preserve the existing WFO Promo content type for the moment, and to create a completely new content type called WFO Information. (Removal will be done in #1486)
Phone numbermoduleWe will now use the Phone number module to give us an actual typed phone number field across the system, with validation and configuration options. This field will now be used on the WFO Information content type.
AddressmoduleWe will also be using the Address module, which gives us a typed field for physical addresses with configuration options and validation on entry. This field will be used by the WFO Information content type.