Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support description-embedded locations with multiple states #1465

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

greg-does-weather
Copy link
Collaborator

What does this PR do? 🛠️

Our solution to parsing location information from alert description text (#1296) incorrectly assumed that these alerts would only contain locations for a single state. When an alert covering more than one state is included, we mistakenly parse the heading for that state (the part that reads IN [STATE] THIS WARNING INCLUDES [NUMBER] COUNTIES) as being the heading for a group of counties.

This is primarily a presentation bug, as the total list of counties and their appropriate county area headings all continue to be displayed as expected. There's just one (or more) weird headings. This PR removes the weird headings.

Rather than trying to finagle the regex to either exclude the extra state headings or break on them, I opted to instead add a filter to our county region heading checks. Since our existing regex will capture the state headings as county region headings, I just skip any entries in our built-up list of county region headings that are, in fact, state headings. (The code is probably clearer than written English...)

What does the reviewer need to know? 🤔

  • Added unit tests for this one instead of a Playwright test. That seemed easier in this case.

Screenshots (if appropriate): 📸

before
after

Copy link
Collaborator

@eric-gade eric-gade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, LGTM 👍

Code Review Checklist

This is an automated comment on every pull request requiring a review. A checked item is either an assertion that I have tested this item or an indication that I have verified it does not apply to this pull request.

The Basics

  • Checks are passing
  • I read the code
  • I ran the code
  • (if applicable) Post deploy steps are run
  • (if applicable) I validated the change on the deployed version in

Documentation

  • changes to “how we do things” are documented in READMEs
  • all new functions and methods are commented using plain language
  • any new modules added documented in modules.md

Security

  • security false positives are documented
  • data from external sources is cleaned and clearly marked

Reliability

  • error handling exists for unusual or missing values
  • interactions with external systems are wrapped in try/except
  • functionality is tested with unit or integration tests
  • dependency updates in composer.json also got changed in composer-lock.json

Infrastructure

  • all changes are auditable and documented via a script
  • it is clear who can and should run the script
  • (if applicable) diagrams have been updated or added in PlantUML

Accessibility

  • New pages have been added to cypress-axe file so that they will be tested with our automated accessibility testing
  • Meets WCAG 2.0 AA or 2.1 AA for Section 508 compliance
    • Site is keyboard accessible. All interactions can be accessed with a keyboard
    • Site is free of keyboard traps. The keyboard focus is never trapped in a loop
    • All form inputs have explicit labels
    • Form instructions are associated with inputs
    • All relevant images use an img tag
    • All images have appropriate alt attributes
    • Multimedia is tagged. All multimedia has appropriate captioning and audio description
    • Text has sufficient color contrast. All text has a contrast ratio of 4.5:1 with the background
    • Site never loses focus. Focus is always visible when moving through the page with the keyboard
    • Tab order is logical
    • Tables are coded properly. Tables have proper headers and column attributes
    • Headings are nested properly. Heading elements are nested in a logical way
    • Language is set. The language for the page is set
    • CSS is not required to use the page. The page makes sense with or without CSS
    • Links are unique and contextual. All links can be understood taken alone, e.g., ‘Read more - about 508’
    • Page titles are descriptive

Device Matrix

  • firefox/gecko (renders correctly and user interactions work)
  • chrome/chromium/edge (renders correctly and user interactions work)
  • safari/webkit (renders correctly and user interactions work)
  • web page is readable and usable
    • at 480px (mobile)
    • at 640px (tablet)
    • at 1024px (desktop)

@greg-does-weather greg-does-weather merged commit 0644a7e into main Jul 25, 2024
17 checks passed
@greg-does-weather greg-does-weather deleted the mgwalker/1425-alert-location-parsing-bug branch July 25, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing counties/cities from watches/warnings is sometimes not quite correct
2 participants